1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/getmsg.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Dec 19 16:09:15 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/90310234a0396f4bb4a5d508
    Modified Files:
    src/sbbs3/getmsg.cpp
    Log Message:
    In Raw I/O mode, disable markup support and @-code expansion

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Jan 20 23:00:27 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/f039b2aa3d8c26807b35390e
    Modified Files:
    src/sbbs3/getmsg.cpp
    Log Message:
    Clean-up MIME-Decoded plain-text format message

    Don't display at all if smb_getplaintext() returns a blank string.
    Don't display "(null)" if there's no text sub-type.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jul 3 15:55:50 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/bd725db622999e7311ab340e
    Modified Files:
    src/sbbs3/getmsg.cpp
    Log Message:
    Paranoia around use of smb.subnum as an index into scfg.sub[]

    Use the is_valid_subnum() function before using the smb.subnum as an index into (s)cfg.sub[]. Related to the previous committed fix of writemsg(): leaving the global smb.subnum as -1 (INVALID_SUB) after replying to a post via email or netmail, resulting in a crash here.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed May 6 22:36:57 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/55eaccec35c18dc552485d8a
    Modified Files:
    src/sbbs3/getmsg.cpp
    Log Message:
    getmsg: guard idx.number underflow in getmsgnum (CID 530525)

    When smb_getmsgidx_by_time succeeded but returned idx.number == 0
    (should not happen for valid messages, but defensively), 'idx.number - 1' underflowed uint32_t and produced 0xFFFFFFFF == ~0, the function's
    error sentinel — accidentally correct, but undefined per signed-int
    return. Make the zero-number case explicitly return ~0.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net