1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/un_qwk.cpp un_rep.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Nov 29 11:08:25 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/11495220c2fd6260ad8cd200
    Modified Files:
    src/sbbs3/un_qwk.cpp un_rep.cpp
    Log Message:
    Bug-fix: erroneously filtering vote messages by age

    This bug was introduced in commit 9c91d32a8617 2 years ago and would result
    in votes and poll message being erroneously filtered. e.g.
    !Filtering QWK message from (null) due to age: 19321 days

    The filter criteria was either a zero-initialized msg or the previously parsed/imported msg from the QWK or REP packet.

    A solution for filtering vote/poll messages is needed, but this isn't it.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Sep 11 20:26:18 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/29a35642160a7f4148134ce3
    Modified Files:
    src/sbbs3/un_qwk.cpp un_rep.cpp
    Log Message:
    Blocked IP addresses in ip-silent.can weren't filtered from QWK and REP pkts

    The "from_ip" header field of QWK messages is checked against blocked IP addresses, but was only checking against IP addresses from ip.can, not any addresses listed in ip-silent.can. These 2 list files are now merged together for the purposes of filtering during QWK/REP packet import.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu Sep 12 21:37:53 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/aff554a44aa48a1e1565f450
    Modified Files:
    src/sbbs3/un_qwk.cpp un_rep.cpp
    Log Message:
    Fix crash due to use after free or double-free

    ... bug introduced in commit 29a35642160a7f4.

    strListMerge() doesn't realloc the strings in the list, so we don't want to free the strings in this list here.

    This is likely the cause of the crash Keyop eluded to in #synchronet.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Dec 5 21:40:24 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/b4cf201d6f4ee91eea9adf7b
    Modified Files:
    src/sbbs3/un_qwk.cpp un_rep.cpp
    Log Message:
    Verify QWK messagse files (e.g. MESSAGES.DAT) is multiple of QWK block size

    (128 bytes)

    Fix up the filename in error messages reported during unpacking QWK packets (MESSAGES.DAT not BBSID.QWK).

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed May 6 19:41:53 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/de5f05837b15d144b2c14b17
    Modified Files:
    src/sbbs3/un_qwk.cpp un_rep.cpp
    Log Message:
    un_qwk/un_rep: suppress listFree FORWARD_NULL false-positive (CIDs 631130, 631142)

    user_list is zero-initialized as link_list_t{0}. listFree's only
    list->sem dereference is gated on (list->flags & LINK_LIST_SEMAPHORE),
    which is never set here, so the call is safe. Coverity loses track of
    the flag check; document the invariant and suppress the FORWARD_NULL
    warning at both call sites.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net