1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • exec/tests/filebase/update.js src/sbbs3/js_filebase.cpp

    From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon Sep 21 22:21:21 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/58cefb15dd6d3efa9d6f776d
    Modified Files:
    exec/tests/filebase/update.js src/sbbs3/js_filebase.cpp
    Log Message:
    FileBase: an object of only auxdata or a header value is not an error

    parse_file_properties() started from SMB_ERR_NOT_FOUND and cleared it
    only when a property that adds a header *field* was present, so add()
    and update() rejected a file object made up of nothing but extdesc,
    auxdata, cost, added, times_downloaded or anon.
    FileBase.update(name, {auxdata: "..."}) returned false with status -110
    and wrote nothing.

    Nothing at the call sites tells that code apart from a real failure;
    both simply test for SMB_SUCCESS. Start from success instead, so a
    partial update carrying no header field is applied like any other.

    Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net