https://gitlab.synchro.net/main/sbbs/-/commit/aaf3d2395407e9e30d3f54e1
Modified Files:
docs/v322_new.md src/sbbs3/ftpsrvr.cpp mailsrvr.cpp main.cpp services.cpp userdat.c userdat.h websrvr.cpp
Log Message:
PROXY protocol: check temporary login bans against the client's address
With HAPROXY_PROTO, the Terminal and Web Servers record a failed login
under the client's address from the PROXY protocol header, but
loginBanned() looked up the socket's peer, the proxy, so a client's
temporary ban never took effect. With the proxy on the same system it
also matched the server's own address, which is never banned.
loginBanned()'s unused host_name parameter is now client_addr: the
client's address when it is not the socket's peer, or NULL to use the
peer as before. The Terminal and Web Servers pass the address the
connection was accepted with (from the PROXY header when one was read);
the FTP and Mail Servers and Services pass NULL. The rule that the
server connecting to itself is never banned now compares that address.
Tested on Linux with the Web Server behind a trusted PROXY protocol
peer and a temporary-ban threshold of 3: after three wrong passwords
from one client address, its next connection was refused with
!TEMPORARY BAN, while another client address logged in. The Terminal
Server change was built, not exercised.
Co-Authored-By: Claude Opus 5.5 <
noreply@anthropic.com>
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net