1. Forum
  2. FSXNet
  3. FSX MYS

  • and another bug ...

    From Oli@21:1/151 to All on Tue Dec 3 18:45:42 2019
    I wondered why Crashmail shows an invalid month in the packet date:

    Tossing 027deab2.pkt (3K) from 21:1/100.0 (04-???-19 05:01:05) / 4d

    It turns out Mystic uses 1 to 12 instead of 0 to 11 for the month as specified in FSC-39:

    Type-2 Packet Format (proposed, but currently in use) -----------------------------------------------------
    Field Ofs Siz Type Description Expected value(s)
    ------- --- --- ---- -------------------------- -----------------
    OrgNode 0x0 2 Word Origination node address 0-65535
    DstNode 2 2 Word Destination node address 1-65535
    Year 4 2 Int Year packet generated 19??-2???
    Month 6 2 Int Month " " 0-11 (0=Jan)
    Day 8 2 Int Day " " 1-31
    Hour A 2 Int Hour " " 0-23
    Min C 2 Int Minute " " 0-59
    Sec E 2 Int Second " " 0-59

    ---
    * Origin: (21:1/151)
  • From Jeff Smith@21:1/128 to Oli on Tue Dec 3 16:11:38 2019
    Hello Oli,

    Another bug? Really??

    I wondered why Crashmail shows an invalid month in the packet date:
    Tossing 027deab2.pkt (3K) from 21:1/100.0 (04-???-19 05:01:05) / 4d

    Probably because January IS the first month of the year. Also probably why people born say on January 24 1990 don't consider themselves born on 00/24/1990.
    And why software uses a date structure that IS currently in use.

    It turns out Mystic uses 1 to 12 instead of 0 to 11 for the month as specified
    in FSC-39:

    You mean "proposed, but not currently in use"?

    BTY, This is EOT for me for this pointless thread.


    Jeff


    --- BBBS/Li6 v4.10 Toy-4
    * Origin: FSXNET: The Ouija Board - bbs.ouijabrd.net (21:1/128)
  • From Oli@21:1/151 to Jeff Smith on Thu Dec 5 18:15:35 2019
    Hello Oli,

    Another bug? Really??

    Hi Jeff! Yes, really!

    I wondered why Crashmail shows an invalid month in the packet date:
    Tossing 027deab2.pkt (3K) from 21:1/100.0 (04-???-19 05:01:05) /
    4d

    Probably because January IS the first month of the year. Also
    probably why people born say on January 24 1990 don't consider
    themselves born on 00/24/1990.
    And why software uses a date structure that IS currently in use.

    I agree with you that using 0 to 11 for the months is bonkers, especially when the valid values for the day fields are from 1 to 31. It makes no sense at all,
    but in Fidonet this is the way:

    http://ftsc.org/docs/fts-0001.016
    http://ftsc.org/docs/fsc-0048.002

    (just search for "0-11")

    It turns out Mystic uses 1 to 12 instead of 0 to 11 for the month as
    specified
    in FSC-39:

    You mean "proposed, but not currently in use"?

    You misread that (I also did it several times). The correct quote is "proposed,
    but currently in use" (without the "not"). FSC-39 is _the_ standard packet format that every fidonet tosser supports. Don't ask me why the FTSC never published an FTS for it.

    BTY, This is EOT for me for this pointless thread.

    You are right, completely pointless. It really doesn't matter if there are 11 or 12 bugs in Mystic's Fidonet implementation. It's a pain in the butt with or without this bug ;-P.

    ---
    * Origin: (21:1/151)
  • From apam@21:1/126 to Jeff Smith on Fri Dec 6 07:29:34 2019
    Hello Oli,

    Another bug? Really??

    I wondered why Crashmail shows an invalid month in the packet
    date: Tossing 027deab2.pkt (3K) from 21:1/100.0 (04-???-19
    05:01:05) / 4d

    Probably because January IS the first month of the year. Also
    probably why people born say on January 24 1990 don't consider
    themselves born on 00/24/1990.
    And why software uses a date structure that IS currently in use.

    Most people don't read raw packets. I suspect the reason for 0-11 is
    that arrays are 0 based and in C struct tm is also zero based for
    months. So, when you have an array of months, you have:

    {"Jan", "Feb", "Mar" ... "Oct", "Nov", "Dec"}

    Crashmail adds a month "???" after December to support mailers that are
    1 based, so instead it will just display the incorrect month instead of crashing.

    Andrew

    --- MagickaBBS v0.13alpha (Linux/x86_64)
    * Origin: HappyLand - telnet://magickabbs.com:2023/ (21:1/126)